Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake in conda #45

Merged
merged 5 commits into from
Dec 16, 2022
Merged

cmake in conda #45

merged 5 commits into from
Dec 16, 2022

Conversation

antoinefalisse
Copy link
Collaborator

@antoinefalisse antoinefalisse commented Dec 15, 2022

There is a cmake conda package and it automatically adds cmake to the path. Only one added line in the requirements, but quite an impact for users who do not need to install cmake anymore (a few forum posts already about cmake issues).

Very minor changes required in the code, just changed a few things in the readme. I figured that on linux, you need to install some libraries, so that's been added to the readme too (I had these libraries installed already on my machine).

Tests I've done:

  • I removed CMake from the machine on Windows, Mac, and Linux and could run example_kinetics.py without problems.

BTW I added creating the env file to the general instructions to avoid problems down the line. People trying to run exmaple_kinetics but having issues to authenticate.

@antoinefalisse antoinefalisse changed the title [WIP] cmake in conda? cmake in conda Dec 16, 2022
Copy link
Member

@suhlrich suhlrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic update. thanks!

@antoinefalisse antoinefalisse merged commit 09dc1a3 into main Dec 16, 2022
@antoinefalisse antoinefalisse mentioned this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants